devutils/platform_patches: update shared patches instead of deleting #3517
Conversation
dumbmoron
force-pushed
the
platform-patches-unmerge-rename
branch
from
430ebab to
7cc394a
Compare
Ahrotahn
left a comment
Ahrotahn
left a comment
There was a problem hiding this comment.
This seems fine to me so long as it doesn't cause any issues for other platform maintainers.
|
Arch and NixOS won't be affected I believe, lets wait for everyone else to get a chance to look at this though :) |
|
@ungoogled-software/windows @ungoogled-software/macos |
|
I believe macOS will also be unaffected. Worst case I will try to start a new build with this later to confirm. |
|
I think windows should be unaffected as well. We first apply the common patches before (only) refreshing the platform patches to speedup refresh. |
|
fine for me |
dumbmoron
force-pushed
the
platform-patches-unmerge-rename
branch
from
7cc394a to
eae5d18
Compare
|
I never used this script, so I cannot asses the changes, but if it doesn"t have any side-effects, should we merge the PR? |
|
@PF4Public @Ahrotahn @networkException shouldn't we merge this one? |
|
I've already given my approval! @PF4Public @networkException Were there any objections to merging this? |
networkException
left a comment
networkException
left a comment
There was a problem hiding this comment.
Nope! I'd like to get the zero day bump fix out first though
|
@dumbmoron When you get the time give this one more rebase over the latest changes and I'll merge when I get the chance! |
Instead of deleting copies of generic patches when unmerging them from platform patches, move them back into the shared repository. This makes it much more pleasant and ergonomic to work on patches as a merged series, and allows to e.g. refresh existing patches without having to move them back to the original folder manually.
dumbmoron
force-pushed
the
platform-patches-unmerge-rename
branch
from
eae5d18 to
aebf0a4
Compare
7 participants
Instead of deleting copies of generic patches when unmerging them from platform patches, move them back into the shared repository.
This makes it much more pleasant and ergonomic to work on shared patches in a merged series, and allows to refresh, or otherwise modify existing patches by "unmerging", instead of having to move them back to the original folder manually.
My case for why this potentially breaking change should be made: I have been using this as a personal preference in helium for a few months: imputnet/helium@d56c8d5, and it has made working with patch series much simpler - so much that I believe it should be a default everywhere. To my knowledge, it should not break any build processes, since unmerging is usually done as a manual action by a human when working on patches.